ports/75816: [PATCH] www/firefox: new mozilla.sh and package script

[Joe Marcus Clarke]

On Fri, 2005-02-25 at 09:22 +0100, Jose M Rodriguez wrote:
> El Viernes, 25 de Febrero de 2005 08:56, Joe Marcus Clarke escribió:
> > Synopsis: [PATCH] www/firefox: new mozilla.sh and package script
> >
> > State-Changed-From-To: open->closed
> > State-Changed-By: marcus
> > State-Changed-When: Fri Feb 25 07:52:11 GMT 2005
> > State-Changed-Why:
> > I've committed some of this.  What I didn't commit was the PIS work. 
> > While the framework might be there to embed RC scripts into Mozilla
> > and Firefox, I don't think this is the right place to add sound
> > server support. I don't want to get bogged down in a lot of local
> > scripts that make these ports unsupportable, or in violation of our
> > license agreement with Mozilla.
> >
> 
> Please, consider the cleanhome moz_pis for firefox.  This makes firefox 
> upgrades don't be hurt by local profile.

This could be useful.  However, I have some concerns, and the comments
in the script didn't help.  This removes the pluginreg.dat every time
Firefox is started.  Will that have any negative effects?  What about
performance?   Couldn't this be wrapped about the -ot comparison as
well?  Also, you have a typo.  The file is XUL.mfasl, not XUL.mfast.

Other than that, this is a very clever script, and will probably make
upgrades more painless.

> 
> > As for your pkg-[de]install work, I didn't see a real advantage of
> > moving some of these things out into scripts.  Plus, it looks like
> > your pkg-deinstall would nuke all of browser_plugins.
> >
> 
> Only make this happens from packages, not only from ports.  As an 
> example, you get the java plugin working when you install the 
> firefox/mozilla package. I'll investigate the pkg-deinstall.

I think we'll revisit this for 1.1.  Thus far, no one has complained,
and since the 1.0.1 update went fairly smoothly, I'd rather not rock the
boat.  Please resubmit a patch for this when you figure out the
pkg-deinstall problem.

Joe

> 
> > The rest of patches looked okay, and were merged.  In the future,
> > please do all diffs frome one level above the directory in question. 
> > For example:
> >
> > diff -ruN firefox.orig firefox
> >
> > This makes patching much easier.  Also, please don't submit diffs
> > against CVS versions.  If a new version hasn't been released, either
> > wait, or submit the diff against the current version in the ports
> > tree.  Thanks.
> >
> 
> --
>   josemi
> > http://www.freebsd.org/cgi/query-pr.cgi?pr=75816
> 
> 
-- 
Joe Marcus Clarke
FreeBSD GNOME Team      ::      gnome at FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/freebsd-gnome/attachments/20050226/e75ccb00/attachment.bin