FreeBSD 6.3-Release fixit and gmirror (7.0-RC1 too)

[Ulf Lilleengen]

On Fri, Feb 01, 2008 at 10:31:34AM +0100, Ulf Lilleengen wrote:
> On tor, jan 31, 2008 at 09:30:24am -0600, Eric F Crist wrote:
> > Hello folks,
> > 
> > I've got a problem with geom and 6.3-RELEASE/7.0-RC1 that is described in 
[...]
> >>> three install CDs, rather than 2, which has been historical, without
> >>> considering the documentation CD.
> >> 
> >> It is a bug, and quite silly one. I remember there has been attempt at
> >> fixing it (AFAIK the proposed solution was to ad an environment
> >> variable pointing to the correct directory) but either it was done
> >> wrongly or somebody forgot to MFC the change. It's an annoying little
> >> problem when trying to set up a new system and it should have been
> >> fixed ages ago.
> I committed the fix after testing it with RELENG_7. The problem was that not
> all the GEOM libraries was loaded since the libary path was not set. This fix
> added the GEOM_LIBRARY_PATH environment-variable to the fixit-environment,
> and was added in rev 1.11 of src/release/fixit.profile
> 
> I tested this fix by generating a livefs-CD and it did fix the issue with the
> libraries not being loaded.
> 
> The change was also MFCed to RELENG_7, RELENG_6 and RELENG_6_3. More about
> the issue can be found in PR misc/113543. 
> 
> I don't think the fix was incorrect,  but I'll try reproduce this and try
> find a fix for this case.
> 
Now that I think about it, you're procedure here is to chroot /dist before
you execute the gmirror commands. Since the library path is pointed at
/mnt2/lib/geom , when you chroot it still points there, but should point at
/lib/geom which is the default. So, one way to fix this is simply just unset
the PATH when you get into the environment or don't chroot /dist at all.

I just tested my theory in qemu, and it seems to be right. If i do a 
chroot /dist and
unset GEOM_LIBRARY_PATH 
the whole command set appears again.

It would be nice if someone else also tried and checked if this is the case.

I'm not sure if this should be fixed or not, since someone may perfer to use
gmirror outside the chroot (which was the problem the patch solved in the
first case), or inside the chroot. Perhaps adding a symlink outside from
/dist/lib/geom to /lib/geom  would be a better fix.

-- 
Ulf Lilleengen