HEAD tty seems to drop characters

[Kostik Belousov]

On Sun, Aug 02, 2009 at 02:31:08PM +0200, Ed Schouten wrote:
> Hi Kostik,
> 
> * Kostik Belousov <kostikbel at gmail.com> wrote:
> > I run a screen(1), where I tried to copy large portion of output and
> > paste it into vi. This resulted in the loss of the characters at random
> > points inside the pasted text.
> 
> I already took some time to investigate the issue. I have attached a
> patch that should already improve the situation:
> 
> - write() on a pseudo-terminal master also accounted the data that was
>   read into the kernel, but couldn't be passed to the TTY (which is
>   likely to happen in non-blocking mode).
> 
> - There was also a small unrelated issue; input on a TTY which has been
>   configured in block (bypass) mode wouldn't set the input high water
>   mark.
> 
> For some reason, the data loss doesn't occur when SSHing to myself
> multiple times, but still causes screen(1) to drop some bytes later on.
> 
> Even though it's always very easy to blame other applications, I suspect
> this may be because I reduced the input buffer size from 8 KB to 2 KB
> per pseudo-terminal. Maybe screen(1) can't deal with this. To be
> investigated...
At least, it is an improvement for me. Patch looks good.
Please consider this as an approval for the commit.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20090802/0bf6e397/attachment.pgp