VOP_* changes causes NULL ptr dereference for acl_get_file(3)

[Robert Watson]

On Thu, 2 Dec 2004, Mark Santcroos wrote:

> I need at least the following patch to keep my system alive.  A simple
> call to acl_get_file(3) is enough to crash the machine. 
> 
> You will have to think a bit more about how you want to initialize stuff
> or about better defaults for cases like ACLs. 

Should probably be using VOP_EOPNOTSUPP rather than VOP_EINVAL, I think.
Also, it's likely that if you need a vop_getacl entry here, you probably
also want a vop_setacl and a vop_checkacl entry.

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert at fledge.watson.org      Principal Research Scientist, McAfee Research


> 
> Mark
> 
> ==== //depot/projects/custom/kern/vfs_default.c#35 - /home/marks/proj/perforce/projects/custom/kern/vfs_default.c ====
> @@ -95,6 +95,7 @@
>  	.vop_revoke =		VOP_PANIC,
>  	.vop_strategy =		vop_nostrategy,
>  	.vop_unlock =		vop_stdunlock,
> +	.vop_getacl =		VOP_EINVAL,
>  };
>  
>  /*
> 
> -- 
> RIPE NCC - Delft University of Technology - The FreeBSD Project
> marks at ripe.net - m.a.santcroos at ewi.tudelft.nl - marks at freebsd.org
> _______________________________________________
> freebsd-current at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe at freebsd.org"
>