bin/151713: Bug in Growfs, plus patches
Dean Hamstead
dean at fragfest.com.au
Mon Oct 25 11:20:12 UTC 2010
>Number: 151713
>Category: bin
>Synopsis: Bug in Growfs, plus patches
>Confidential: no
>Severity: serious
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Oct 25 11:20:09 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Dean Hamstead
>Release: 8.1 RELEASE
>Organization:
FragFest
>Environment:
[dean at batou ~]$ uname -a
FreeBSD batou.fragfest.net.au 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Mon Jul 19 02:36:49 UTC 2010 root at mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
Growfs has a 32bit integer internall, where it should have a 64bit. This has the effect that filesystems over a certain size cant be enlarged.
>How-To-Repeat:
Try to enlarge a filesystem whos size is beyond 2^32
>Fix:
Hi Growfs team
I believe i have uncovered a bug in growfs related to 32bit integers.
My original enquirey to freebsd-fs at freebsd is archived at ...
http://marc.info/?l=freebsd-fs&m=128533133814268
You can see that i have enlarged a disk where i had previous formatted it
without slices/partitions. I then wanted to grow the filesystem to match.
I dont believer there is a problem with the slices/noslices side of
things, but i believe there is an integer looping inside growfs which is
causing it to refuse to enlarge.
I poked around in the source code and i believe that the p_size variable
should be 64bit.
Some googling shows support for this theory...
here is another person reporting the same problem as myself
first post -
http://fixunix.com/freebsd/293354-growfs-filesystem-size-limits.html
discussion about p_size -
http://fixunix.com/freebsd/293353-re-growfs-filesystem-size-limits.html
further discussion -
http://fixunix.com/freebsd/293364-re-growfs-filesystem-size-limits.html
here is a much more recent thread with the same sort of problem
http://forums.freebsd.org/showthread.php?t=15252
which includes a link to patch for an older version of growfs
http://masq.tychl.net/growfs.patch
Which expands upon the changes outlined in the 'fixunix.com' discussion.
I am hoping that you can make appropriate changes in growfs and release
them in to freebsd.
Thank you for your good work.
Dean
>Release-Note:
>Audit-Trail:
>Unformatted:
More information about the freebsd-bugs
mailing list