PinebookPro misc drivers..

Emmanuel Vadot manu at bidouilliste.com
Wed Mar 10 15:01:19 UTC 2021


On Wed, 10 Mar 2021 15:29:21 +0100
Søren Schmidt <soren.schmidt at gmail.com> wrote:

> Hi
> 
> I?ve uploaded the latest from my PinebookPro collection here:
> https://people.freebsd.org/~sos/PinebookPro/ <https://people.freebsd.org/~sos/PinebookPro/>
> 
> Comment,, bugs, etc welcome?

 Few comments,

 - Could you at least share patches generated with git diff ?
 - rk_gpiokeys.c doesn't seems correct, we already have
sys/dev/gpio/gpiokeys.c so patch this one if it isn't enough for lid
switch need.
 I could comment more if I would be able to diff more easily.

> PS: and no I left my commit bit for safe keeping with core many years ago?.

 You could still open reviews on phab :)

> --
> Søren Schmidt
> sos at deepcore.dk / sos at freebsd.org
> "So much code to hack, so little time"
> 
> 
> 
> _______________________________________________
> freebsd-arm at freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-arm
> To unsubscribe, send any mail to "freebsd-arm-unsubscribe at freebsd.org"


-- 
Emmanuel Vadot <manu at bidouilliste.com> <manu at freebsd.org>


More information about the freebsd-arm mailing list