[Differential] [Commented On] D2340: Support for Alpine platform from Annapurna Labs

[andrew (Andrew Turner)]

andrew added a comment.

Two points:

1. If there is any chance the vendor code will ever be updated it should be committed though the vendor area in subversion.
2. I think the pci driver isn't ready, can you create a new review for just this.


INLINE COMMENTS
  sys/arm/annapurna/alpine/alpine_machdep_mp.c:89 This needs a newline:
  
    boolean_t
    alpine_validate_cpu(...)
  
  Should it be static?
  sys/arm/annapurna/alpine/alpine_machdep_mp.c:174 Missing space, should be `base = 0;`, and the same for size.
  sys/arm/annapurna/alpine/alpine_machdep_mp.c:176   if (pbase == NULL || psize == NULL)
  sys/arm/annapurna/alpine/alpine_machdep_mp.c:277 This has the same style issues as alpine_get_nb_base.
  sys/boot/fdt/dts/arm/annapurna-alpine.dts:2 So they will be released in Linux 4.1. We should try to reduce the difference between what we add and the 4.1-rc3 files.

REVISION DETAIL
  https://reviews.freebsd.org/D2340

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: jpa-semihalf.com, ian, andrew, imp
Cc: emaste, meloun-miracle-cz, onwahe-gmail-com, freebsd-arm