[Differential] [Commented On] D2340: Support for Alpine platform from Annapurna Labs

[emaste (Ed Maste)]

emaste added inline comments.

INLINE COMMENTS
  sys/arm/annapurna/alpine/hal/al_hal_iofic.h:1 For reference, the appropriate top-level vendor directory: https://svnweb.freebsd.org/base/vendor-sys/
  
  You'd import a verbatim copy of an upstream release, then merge it to sys/contrib and apply any changes necessary.  Let me know if you'll need help with the process.
  sys/arm/annapurna/alpine/hal/al_hal_iofic.h:1 True, but it's a lot more awkward to retrofit the vendor import if there is a new update in the future. If nothing else we should at least reference the hal drop in the commit message - e.g. something like
  ```
  The files in the hal/ subdirectory are an unmodified copy of 
  <annapurna-alpine-hal-20150317.txz> with sha1 hash
  f1d2d2f924e986ac86fdf7b36c94bcdf32beec15.
  ```

REVISION DETAIL
  https://reviews.freebsd.org/D2340

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: jpa-semihalf.com, ian, andrew, imp
Cc: emaste, meloun-miracle-cz, onwahe-gmail-com, freebsd-arm