[Differential] [Commented On] D2377: Introduce ARM GICv3 support

ian (Ian Lepore) phabric-noreply at FreeBSD.org
Tue May 12 15:35:55 UTC 2015


ian added inline comments.

INLINE COMMENTS
  sys/arm64/arm64/gic_v3.c:163 This comment is now completely detached from the code it was commenting on.
  
  My point was that these two lines are equivelent:
  
    (*init_func)();
    init_func();
  
  When you've got a pointer to a function, the compiler knows that, there's no need to add parens and a star to make it call through the pointer.

REVISION DETAIL
  https://reviews.freebsd.org/D2377

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: zbb, emaste, ian, imp, andrew, brueffer, joel, wblock
Cc: kostikbel, emaste, andrew, imp, freebsd-arm


More information about the freebsd-arm mailing list