[Differential] [Commented On] D2377: Introduce ARM GICv3 support

emaste (Ed Maste) phabric-noreply at FreeBSD.org
Mon May 11 19:05:01 UTC 2015


emaste added inline comments.

INLINE COMMENTS
  sys/arm64/arm64/gic_v3.c:191 > So now we have to comment on allocation and deallocation?
  
  Actually, you could just put a single kassert above at line 140 since we'll already break if rid > INT_MAX on
  `sc->gic_res[rid] = bus_alloc_resource_any(dev, SYS_RES_MEMORY, `

REVISION DETAIL
  https://reviews.freebsd.org/D2377

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: zbb, emaste, ian, imp, andrew, brueffer, joel, wblock
Cc: kostikbel, emaste, andrew, imp, freebsd-arm


More information about the freebsd-arm mailing list