Code review request: boards on AT91

Rafał Jaworowski raj at semihalf.com
Tue Nov 25 13:39:13 PST 2008


On 2008-11-25, at 22:19, M. Warner Losh wrote:
> : > If anybody wants me to write up where I'm going with this, or  
> answer
> : > any question, please feel free to ask.  Also, comments would be  
> nice.
> :
> : I was dreaming once about all-generic initarm() that would have  
> KOBJ-
> : based dispatcher, but am not sure this wouldn't cause some chicken- 
> and-
> : egg issues as some parts of the infrastructure might not be  
> available
> : at such early stages, but didn't investigate this too close, any
> : thoughts? But anyways, even a simple scheme with common logic and
> : function ptrs, which each platform variation would implement their  
> own
> : routines (or use generic), would improve the ARM init code
> : significantly.
>
> Yes.  There's much duplication of code now, and I'd love to work
> towards ways of coping with less duplication.  I'd also like to see
> the ability to compile code either for multi-board support, or just a
> single board support.  For the moment, I'd like to take the first step
> and get to have the latter...
>
> The Marvell/Orion stuff has a much better separation, but still needs
> some tweaks for board level support.  I think I'm going to write up
> what I've done and put it on a wiki and then ask if you could review
> it and see if your experience with the Marvell implementation could
> help refine it.

Great, let me know when you got something in the wiki.

Rafal


More information about the freebsd-arm mailing list