timeout/callout small step forward

[Jeff Roberson]

On Wed, 2 Apr 2008, John Baldwin wrote:

> On Saturday 29 March 2008 03:04:17 am Jeff Roberson wrote:
>> http://people.freebsd.org/~jeff/callout.diff
>>
>> This patch takes the current callout implementation and makes it per-cpu.
>> It also hides callout details from the rest of the kernel by making the
>> callwheel structure private to kern_timeout.c among other things.
>
> Looks good.  The kern_intr.c diff has a small bug (forgot to remove the return
> (intr_event_create(...)) from swi_add()).  A few style suggestions would be

Ah thanks.  I had fixed this in a tree but didn't update the patch.  Now 
it's in current.  I'll check that in.

> to always leave a blank line before a comment (I think I saw this in
> kern_calloutwheel_init()?) and usually there isn't a blank line before a
> SYSINIT().  Maybe make the panic messages when creating softclock threads
> more specific, but that's very minor.

Ok, I think kern_timeout.c could use some reformating and refactoring 
as well but I didn't want to tie this commit to that.  Some of those 
functions get too deep and should be broken off into simpler routines.

Thanks,
Jeff

>
> -- 
> John Baldwin
>