timeout/callout small step forward

John Baldwin jhb at freebsd.org
Wed Apr 2 11:17:46 PDT 2008


On Saturday 29 March 2008 03:04:17 am Jeff Roberson wrote:
> http://people.freebsd.org/~jeff/callout.diff
>
> This patch takes the current callout implementation and makes it per-cpu.
> It also hides callout details from the rest of the kernel by making the
> callwheel structure private to kern_timeout.c among other things.

Looks good.  The kern_intr.c diff has a small bug (forgot to remove the return 
(intr_event_create(...)) from swi_add()).  A few style suggestions would be 
to always leave a blank line before a comment (I think I saw this in 
kern_calloutwheel_init()?) and usually there isn't a blank line before a 
SYSINIT().  Maybe make the panic messages when creating softclock threads 
more specific, but that's very minor.

-- 
John Baldwin


More information about the freebsd-arch mailing list