Powerd patch review

[Nate Lawson]

Matteo Riondato wrote:
> On Sat, Sep 30, 2006 at 12:26:30PM -0700, Nate Lawson wrote:
>> Matteo Riondato wrote:
>>> Hi folks,
>>>   I'm writing you to ask if you could be so kind to review the
>>> attached patch to src/usr.sbin/powerd/powerd.c . It should fix the
>>> problem descripted in PR bin/97198. I haven't a broken BIOS to test if
>>> it really works, but it should. 
>>> Thanks
>>> Best regards
>>> P.s. I'm not subscribed to the list, so please CC me.
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>> Index: powerd.c
>> I thought this was already fixed and merged in July by Bruno.  In any 
>> case, the right place to fix this is in the cpufreq driver (or 
>> acpi_perf, where I think this only occurs).  See rev 1.21.2.3 of 
>> acpi_perf.c.
> 
> Yes. PR was filed before that change, which, from my understanding,
> solves the issue. Sorry for the noise.
> 
>> Actually, it would be important to see if this is happening in another 
>> driver.  The output of "sysctl dev.cpu" will show all the child drivers 
>> and settings so we can see if he's using acpi_perf or some other cpufreq 
>> driver.
> 
> I'll ask the PR submitter. Thanks.
> Best regards

Also check if 6-stable fixes the problem for him.  If so, this issue is 
closed.

-- 
Nate