Powerd patch review

Matteo Riondato matteo at freebsd.org
Sat Sep 30 15:18:24 PDT 2006


On Sat, Sep 30, 2006 at 12:26:30PM -0700, Nate Lawson wrote:
> Matteo Riondato wrote:
> >Hi folks,
> >   I'm writing you to ask if you could be so kind to review the
> >attached patch to src/usr.sbin/powerd/powerd.c . It should fix the
> >problem descripted in PR bin/97198. I haven't a broken BIOS to test if
> >it really works, but it should. 
> >Thanks
> >Best regards
> >P.s. I'm not subscribed to the list, so please CC me.
> >
> >
> >------------------------------------------------------------------------
> >
> >Index: powerd.c
> 
> I thought this was already fixed and merged in July by Bruno.  In any 
> case, the right place to fix this is in the cpufreq driver (or 
> acpi_perf, where I think this only occurs).  See rev 1.21.2.3 of 
> acpi_perf.c.

Yes. PR was filed before that change, which, from my understanding,
solves the issue. Sorry for the noise.

> Actually, it would be important to see if this is happening in another 
> driver.  The output of "sysctl dev.cpu" will show all the child drivers 
> and settings so we can see if he's using acpi_perf or some other cpufreq 
> driver.

I'll ask the PR submitter. Thanks.
Best regards
-- 
Matteo Riondato
FreeBSD Committer (http://www.freebsd.org)
G.U.F.I. Staff Member (http://www.gufi.org)
FreeSBIE Developer (http://www.freesbie.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-acpi/attachments/20060930/430bde5e/attachment.pgp


More information about the freebsd-acpi mailing list