cvs commit: ports/audio/clementine-player Makefile ports/audio/clementine-player/files patch-src-devices-cddadevice.h patch-src-devices-cddalister.cpp

[Veniamin Gvozdikov]

I'm agree.

2012/1/16 Ruslan Mahmatkhanov <cvs-src at yandex.ru>:
> Max Brazhnikov wrote on 16.01.2012 22:38:
>
>> On Fri, 13 Jan 2012 03:38:22 +0000 (UTC), Ruslan Mahmatkhanov wrote:
>>>
>>> rm          2012-01-13 03:38:22 UTC
>>>
>>>   FreeBSD ports repository
>>>
>>>   Modified files:
>>>     audio/clementine-player Makefile
>>>   Added files:
>>>     audio/clementine-player/files patch-src-devices-cddadevice.h
>>>                                   patch-src-devices-cddalister.cpp
>>>   Log:
>>>   - let it build with stock gcc
>>>   - optionify ipod and mtp support (default on)
>>
>>
>> This type of `port optionification' leads to a nasty problem of hidden
>> dependencies when options are unchecked, but corresponding libraries are
>> presented. Please consider to commit the patch, which makes optional
>> support
>> really optional.
>>
>> Max
>
>
> You are right, thank you.
> Veniamin, do you have any objections if this patch will be committed?
>
> --
> Regards,
> Ruslan
>
> Tinderboxing kills... the drives.



-- 
Phone: +7 916 948 58 30
Site: http://zlonet.ru
OpenGPG:
g.veniamin(at)googlemail(dot)com | 9B9E5154
XMMP: zloidemon(at)jabber(dot)ru | 19B4A605