cvs commit: ports/audio/clementine-player Makefile ports/audio/clementine-player/files patch-src-devices-cddadevice.h patch-src-devices-cddalister.cpp

Ruslan Mahmatkhanov cvs-src at yandex.ru
Mon Jan 16 18:57:18 UTC 2012


Max Brazhnikov wrote on 16.01.2012 22:38:
> On Fri, 13 Jan 2012 03:38:22 +0000 (UTC), Ruslan Mahmatkhanov wrote:
>> rm          2012-01-13 03:38:22 UTC
>>
>>    FreeBSD ports repository
>>
>>    Modified files:
>>      audio/clementine-player Makefile
>>    Added files:
>>      audio/clementine-player/files patch-src-devices-cddadevice.h
>>                                    patch-src-devices-cddalister.cpp
>>    Log:
>>    - let it build with stock gcc
>>    - optionify ipod and mtp support (default on)
>
> This type of `port optionification' leads to a nasty problem of hidden
> dependencies when options are unchecked, but corresponding libraries are
> presented. Please consider to commit the patch, which makes optional support
> really optional.
>
> Max

You are right, thank you.
Veniamin, do you have any objections if this patch will be committed?

-- 
Regards,
Ruslan

Tinderboxing kills... the drives.


More information about the cvs-all mailing list