4045 zfs write throttle & i/o scheduler performance work

Andriy Gapon avg at FreeBSD.org
Tue Nov 5 08:56:01 UTC 2013


on 25/09/2013 17:39 Andriy Gapon said the following:
> on 15/09/2013 20:08 Andriy Gapon said the following:
>>
>> I wonder if anyone already has a patch for integrating "4045 zfs write throttle
>> & i/o scheduler performance work" from Illumos to FreeBSD.  Or if anyone is
>> working on this.
>>
>> We would like to test this change in our environment as soon as possible.  So I
>> could start working on it if needed.
>>
>> BTW, it seems that "3581 spa_zio_taskq[ZIO_TYPE_FREE][ZIO_TASKQ_ISSUE]->tq_lock
>> is piping hot" was not integrated into FreeBSD despite being committed to
>> Illumos back in February.  I am not sure if we need the main change from this
>> commit, but, as it is frequent with Illumos commits, it contains some changes to
>> definitions of some macros, enums and structs.  So I think it is worth having
>> that change merged, at least partially.  That would help with merge the future
>> changing including "4045 zfs write throttle & i/o scheduler performance work".
>>
> 
> OK, I've done some work on merging these changes.
> Please review:
> https://github.com/avg-I/freebsd/compare/illumos;merge-zfs-write-throttle
> https://github.com/avg-I/freebsd/commits/illumos/merge-zfs-write-throttle
> As I am not sure that I've got everything right, I will appreciate it.
> 
> Especially please see my concerns for this commit:
> https://github.com/avg-I/freebsd/commit/5c7d4daa51c78477c8f0c9af6de7c99a81ff6418
> I am sure that there is something to be concerned about :)

I am going to start committing these (and some more) changes into the tree.
Please try to find some time to review them before that.

Also, I could use an advice on how to put the illumos changes into vendor and
vendor-sys?  Would procedure do you typically use?  Perhaps you have some
script(s) to automate the job?

Additionally, if I switch commit references from illumos mercurial repo to
illumos github git repo, would that be okay with everyone?
My reason is that the latter is a little bit easier to access and browse.
illumos opengrok also uses the git repo for project history.

Thank you!

-- 
Andriy Gapon


More information about the zfs-devel mailing list