STF ZFS test suite, part 2

Steven Hartland killing at multiplay.co.uk
Fri Jun 21 15:22:44 UTC 2013 

----- Original Message ----- 
From: "Alan Somers" <asomers at freebsd.org>
>>>> This appears to be an issue with using /tmp as the target dir, using
>>>> another directory and I can run the import without issue it seems. 
>>>> Other tests also hang with the same issue:-
>>>> zpool_upgrade_002_pos
>>>> zpool_upgrade_003_pos
>>>> zpool_upgrade_007_pos
>>>> zpool_upgrade_008_pos
>>>> zpool_upgrade_009_neg
>>>>
>>>> Would it be an issue to change the directory?
>>>
>>> You should be able to use any output directory at all.  Also, I
>>> usually put TMPDIR on its own UFS filesystem because it makes the
>>> hotspare tests go faster.
>>
>>
>> I've confirmed changing the default TMPDIR fixes ths issue. I believe
>> the problem is in /tmp there's some fifo's, so possibly some bad
>> interaction with those, that and I'm sure its not a good idea to mount
>> a pool over the main system tmp directory ;-)
> 
> The tests shouldn't be mounting a pool on TMPDIR.  If they are, then
> that's a bug.  It's probably something like "mount foo
> ${TMPDIR}/${BAR}", where BAR is undefined.
> Can you tell which test is doing it?

Pretty much all of the zpool_upgrade_* tests I believe the function at
fault is create_old_pool which runs:
log_must $ZPOOL import -d /$TMPDIR $POOL_NAME

Some new issues:-
In the xml log I'm seeing a number of errors, which I believe are setup
problems which could well be causing issues with the tests e.g.
<se>gpart: arg0 'md0': Invalid argument</se>

The following fixes that:-
--- ./include/libtest.kshlib.orig       2013-06-20 00:00:37.923125499 +0000
+++ ./include/libtest.kshlib    2013-06-20 19:02:31.396756337 +0000
@@ -635,7 +635,7 @@ function wipe_partition_table #<whole_di
 {
        while [[ -n $* ]]; do
                typeset diskname=$1
-               $GPART destroy -F $diskname
+               $GPART destroy -F $diskname > /dev/null 2>&1
                shift
        done
 }

A number of tests fail as the ports mkfile is broken and exits 0 when
the file creation fails including:-
refquota_00*_pos, refreserv_001_pos, zpool_add_006_pos,
zpool_create_004_pos

The patch attached fixes this, which I've submitted to the port maintainer.

Here are my current results from stable/9, initally I was seeing 36 unexpected
test failures but with some patches I'm now down to 19 of which I believe
only 4 are actual failures, details below.

== Failure Key ==
! = Broken test
* = Test passed but expected failure
- = Test was broken but now passes with local fixes
? = Possibly broken test
# = Real failure

== Failed test cases ==
 !cli_root/zfs_snapshot/zfs_snapshot:zfs_snapshot_001_neg
  + broken test: multiple snaps can be created
 !cli_root/zpool_import/zpool_import:zpool_import_corrupt_001_pos
  + broken test: dd oseek cant be negative
 !cli_root/zpool_scrub/zpool_scrub:zpool_scrub_003_pos
  + broken test: resliver completes before check for in progress can complete
 !mmap/mmap_write/mmap_write:mmap_write_001_pos
  + broken test: runs out of space
 *cache/cache:cache_009_pos
  + passed: expected failure
 *cli_root/zfs_copies/zfs_copies:zfs_copies_003_pos
  + passed: expected failure
 *cli_root/zfs_create/zfs_create:zfs_create_013_pos
  + passed: expected failure
 *cli_root/zfs_get/zfs_get:zfs_get_009_pos
  + passed: expected failure
 *cli_root/zpool_destroy/zpool_destroy:zpool_destroy_001_pos
  + passed: expected failure
 *hotspare/hotspare:hotspare_add_004_neg
  + passed: expected failure
 *pool_names/pool_names:pool_names_001_pos
  + passed: expected failure
 -cli_root/zfs_rename/zfs_rename:zfs_rename_007_pos
  + failed: clone not creating zvol entry
 -cli_root/zfs_set/zfs_set:readonly_001_pos
  + failed: zvol clone bug
 -cli_root/zfs_set/zfs_set:ro_props_001_pos
  + failed: fixed by mkfile patch
 -cli_root/zpool_add/zpool_add:zpool_add_006_pos
  + failed: fixed by mkfile patch
 -cli_root/zpool_create/zpool_create:zpool_create_004_pos
  + failed: fixed by mkfile patch
 -cli_root/zpool_import/zpool_import:zpool_import_014_pos
  + failed: cant import deleted pools with -D
 -refquota/refquota:refquota_001_pos
  + failed: mkfile doesn't check for any errors on write
 -refquota/refquota:refquota_002_pos
  + failed: mkfile doesn't check for any errors on write
 -refquota/refquota:refquota_003_pos
  + failed: mkfile doesn't check for any errors on write
 -refquota/refquota:refquota_004_pos
  + failed: mkfile doesn't check for any errors on write
 -refquota/refquota:refquota_005_pos
  + failed: mkfile doesn't check for any errors on write
 -refreserv/refreserv:refreserv_001_pos
  + failed: mkfile doesn't check for any errors on write
 -snapshot/snapshot:snapshot_014_pos
  + failed: mkfile doesn't check for any errors on write
 -zil/zil:zil_001_pos
  + failed: broken freeze ioctl
 -zil/zil:zil_002_pos
  + failed: broken freeze ioctl
 -zvol/zvol_misc/zvol_misc:zvol_misc_007_pos
  + failed: recursive zvol rename fails
 -zvol/zvol_misc/zvol_misc:zvol_misc_008_pos
  + failed: zvol rename in promote
 -zvol/zvol_misc/zvol_misc:zvol_misc_009_pos
  + failed: recursive zvol rename fails
 ?cli_root/zpool_create/zpool_create:zpool_create_005_pos 
  + failed: possibly broken test, everything reports SUCCESS?
 ?inuse/inuse:inuse_005_pos
  + passed: expected failure, could be a broken test as everything reports SUCCESS?
 ?zvol_thrash/zvol_thrash:zvol_thrash_001_pos
  + failed: uses camcontrol which fails on md's
 #history/history:history_008_pos 
  + failed: missing history
 #history/history:history_009_pos
  + failed: missing history
 #history/history:history_010_pos
  + failed: missing history
 #snapshot/snapshot:snapshot_018_pos
  + failed: unknown sysctl abbreviated_snapdir

== Before fixes ===
Summary for 102 test programs:
    393 passed test cases.
    36 failed test cases.
    30 expected failed test cases.
    173 skipped test cases.

== After fixes ==
Summary for 102 test programs:
    411 passed test cases.
    18 failed test cases.
    30 expected failed test cases.
    173 skipped test cases.

== Time taken for test suite ==
 1h38m32.62s real                7m6.98s user            36m3.05s sys

I'll be committing the fixes I've found as soon as full head tests are
complete.

    Regards
    Steve

================================================
This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it. 

In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337
or return the E.mail to postmaster at multiplay.co.uk.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch-mkfile.c
URL: <http://lists.freebsd.org/pipermail/zfs-devel/attachments/20130621/3d077e70/attachment.c>

More information about the zfs-devel mailing list