STF ZFS test suite, part 2

[asomers at gmail.com]

On Wed, Jun 19, 2013 at 11:24 AM, Steven Hartland
<killing at multiplay.co.uk> wrote:
> ----- Original Message ----- From: <asomers at gmail.com>
>
>>> I've just given this a wirl on a recent 8/stable and here's
>>> some feedback:-
>>> 1. Be good to mention devel/atf port dependency in README ;-)
>>
>>
>> Done.  BTW, ATF is included in the base in FreeBSD-10
>
>
> Good to know :)
>
>
>>> 2. Initial tests all skip with following, is this expected?
>>> Skipped: Required configuration variable 'X-zfs_acl' not defined
>>
>>
>> Yes, it's expected.  That variable enables tests that depend on
>> Solaris's syntax for ACLs.
>>
>>>
>>> 3. Is there a list of the configuration variables and what they do?
>>
>>
>> Only what's in the README.
>>
>>>
>>> 4. bootfs tests seem to hang at: bootfs_005_neg: ... which is running:
>>> /sbin/zpool import -d //tmp v1-pool
>>>
>>> procstat -k -k 30723
>>>  PID    TID COMM             TDNAME           KSTACK
>>> 30723 100857 zpool            initial thread   mi_switch+0x186
>>> sleepq_catch_signals+0x31c sleepq_wait_sig+0x16 _sleep+0x29d
>>> fifo_open+0x53b
>>> VOP_OPEN_APV+0x62 vn_open_cred+0x2e5 kern_openat+0x16a
>>> amd64_syscall+0x1f4
>>> Xfast_syscall+0xfc
>>>
>>> Top shows:
>>> 30723 root          1  76    0 19056K  1948K fifoor 15   0:00  0.00%
>>> zpool
>>>
>>> After 300 seconds it times out, is this expected?
>>
>>
>> Nope.  That's a bug in FreeBSD 8, apparently.
>
>
> This appears to be an issue with using /tmp as the target dir, using another
> directory and I can run the import without issue it seems. Other tests also
> hang with the same issue:-
> zpool_upgrade_002_pos
> zpool_upgrade_003_pos
> zpool_upgrade_007_pos
> zpool_upgrade_008_pos
> zpool_upgrade_009_neg
>
> Would it be an issue to change the directory?

You should be able to use any output directory at all.  Also, I
usually put TMPDIR on its own UFS filesystem because it makes the
hotspare tests go faster.

>
>
>>> 5. Pretty much all the cache & clean_mirror tests fail, again expected?
>>
>>
>> Not expected.  I think that the cache tests have a bug that makes them
>> fail if you're only running with one disk.  With more disks, they
>> should pass.  Over here, they all pass except for cache_009_pos.
>>
>>>
>>> 6. system deadlocks on test: zfs_rename_008_pos: :(
>>
>>
>> Well, don't run that one ;).
>
>
> This is related to the following PR:
> http://www.freebsd.org/cgi/query-pr.cgi?pr=161968
>
> Doesn't seem to effect current or stable/9 I've only managed to reproduce
> on only stable/8, so already getting benefit from this excellent work :)
>
> Whats the best way to disable a specific test Alan?

The best way to disable a test is to edit the ATF test program file
and add an "atf_skip" statement to the body of the test.  For example,
see zfs_003_neg_body in tests/functional/cli_root/zfs/zfs.

>
>
>>> Be good to get an idea on what the expected results are for standard
>>> FreeBSD installs i.e. stable/8, stable/9 and current?
>>
>>
>> Spectra Logic's custom FreeBSD fork has a lot of bug fixes in ZFS.
>> Will Andrews is slowly pushing those upstream.  As they go in, I would
>> expect FreeBSD-CURRENT to improve.  stable/8 and stable/9, however,
>> are going to do very badly.  About 40 of the tests are marked as
>> expected failures and will show up that way in the ATF results.  Those
>> are the tests that fail in SpectraBSD, and almost all of them should
>> also fail in FreeBSD.  I think that only
>> inuse_005_pos,hotspare_add_004_neg,  zfs_mount_007_pos, and
>> zfs_get_003_pos will pass in FreeBSD but not in SpectraBSD.
>
>
> Thanks Alan, good to know.
>
> Just completed
>    Regards
>    Steve
>
> ================================================
> This e.mail is private and confidential between Multiplay (UK) Ltd. and the
> person or entity to whom it is addressed. In the event of misdirection, the
> recipient is prohibited from using, copying, printing or otherwise
> disseminating it or any information contained in it.
> In the event of misdirection, illegible or incomplete transmission please
> telephone +44 845 868 1337
> or return the E.mail to postmaster at multiplay.co.uk.
>