[OpenZFS Developer] a ZFS SA bug and my patch

[Ned Bass]

On Fri, Nov 22, 2013 at 10:07:06AM -0800, Ned Bass wrote:
> Hi James,
> 
> On Fri, Nov 22, 2013 at 07:27:19AM -0800, James Pan wrote:
> > Hi Ned,
> > Thanks very much for your comments.
> > Actually 'done' is not necessary and can be completely removed.
> > The value of *will_spill is initialized only when buftype is SA_BONUS, so to
> > remove buftype == SA_BONUS from the check, we need to set it to False for
> > SA_SPILL buftype as well.
> > 
> > I've revised the patch to reflect these changes, could you help review it again
> > and get it checked in to the main branch if it is OK?
> > Thanks a lot.
> 
> It looks good to me, except for a couple of formatting issues noted
> below.  We'll get it tested in the Linux port and post results.

This patch checked out well in testing, and it's been merged in the Linux
port:

https://github.com/zfsonlinux/zfs/commit/472e7c6

I recommend that it be considered for inclusion upstream.

Ned