N-way mirror read speedup in zfsonlinux

Matthew Ahrens mahrens at delphix.com
Sun Aug 18 05:06:28 UTC 2013


On Sat, Aug 17, 2013 at 8:08 PM, Steven Hartland <killing at multiplay.co.uk>wrote:

> 2) do {} while() loops have their place, but only if they improve
>>   code clarity and/or yield a significant performance benefit.  I
>>   don't see either applying here.
>>
>
> I'd have to disagree, unless using it makes it difficult to understand,
> a do while should be used is when you know there's always going to be
> one iteration of the loop and hence no need to test before performing
> the first iteration.
>


I agree with Justin.  This nonstandard iteration makes it more difficult to
understand.  I would expect there is no measurable performance benefit,
either.

--matt


More information about the zfs-devel mailing list