[PATCH FOR REVIEW] (For stable/8 only) change default zpool creation version to 28

[Matthew Ahrens]

What if they specify "-d -o feature at ...=enabled"?  It seems like your code
will not find the "version" property set, and then try to set "version=28",
which is not what the user intended.

Also, I'm not sure why you'd need to remove the "version" property if you
are enabling all features.  They shouldn't have specified a version, and I
believe that this error is checked later on.


On Tue, Apr 2, 2013 at 3:10 PM, Xin Li <delphij at delphij.net> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> Hi,
>
> The release engineer team have some concerns of having zpool default
> creation version leave at 5000 (feature flags) because they are not
> supported by "higher" versions of FreeBSD, specifically, 9.0-RELEASE
> (EoL'ed last month) and 9.1-RELEASE.  A user may be surprised if he or
> she "upgrades" a FreeBSD 8.4-RELEASE system to a 9.1-RELEASE system.
>
> In order to solve this, there is a proposal that changes the default
> creation version to 28 instead, as it's supported universally.  The
> attached patch implements this idea.
>
> If there would be no objections in the next 24 hours, I will commit
> this change directly to stable/8 and take care for the releng/8.4
> merge should I get approval for that.  If you have better proposal,
> please do speak up and just go ahead with your version.
>
> Thanks in advance!
>
> Cheers,
> - --
> Xin LI <delphij at delphij.net>    https://www.delphij.net/
> FreeBSD - The Power to Serve!           Live free or die
> -----BEGIN PGP SIGNATURE-----
>
> iQEcBAEBCgAGBQJRW1dUAAoJEG80Jeu8UPuzGCMH/jFEX86BR3ozZDS5TPs5XSJI
> MvjEf3wLllaA+HG2NtVCbKVhMxZvnt4RyQSCWlNHietefiG2uizHu/wf7PXkgTtQ
> Z1yqElo2pXbLVY1jMkp91yVNAsE1hwoyUASc+V3LgZijXTvw10AWqpQI54yOyNfj
> nLn7ic8Tnwa1a05JPoAabsCLAQ9YNStaEt6bo6180gXiD7gBHLibTaD0OuRIVgej
> wOnSfI1o1XK2veYo04PVZLdGEEHeK+mbF1EPna7K6K6EwZ7vfsk6NGp9882lpoKj
> LsW8ctnANUNv8hjfwOCUDQUW1NpjUDzkNvnt4Nfkh9TFfBsZjvbfxfEgS6W62Qk=
> =UGCv
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> zfs-devel at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/zfs-devel
> To unsubscribe, send any mail to "zfs-devel-unsubscribe at freebsd.org"
>