[PATCH FOR REVIEW] (For stable/8 only) change default zpool creation version to 28

[Xin Li]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi,

The release engineer team have some concerns of having zpool default
creation version leave at 5000 (feature flags) because they are not
supported by "higher" versions of FreeBSD, specifically, 9.0-RELEASE
(EoL'ed last month) and 9.1-RELEASE.  A user may be surprised if he or
she "upgrades" a FreeBSD 8.4-RELEASE system to a 9.1-RELEASE system.

In order to solve this, there is a proposal that changes the default
creation version to 28 instead, as it's supported universally.  The
attached patch implements this idea.

If there would be no objections in the next 24 hours, I will commit
this change directly to stable/8 and take care for the releng/8.4
merge should I get approval for that.  If you have better proposal,
please do speak up and just go ahead with your version.

Thanks in advance!

Cheers,
- -- 
Xin LI <delphij at delphij.net>    https://www.delphij.net/
FreeBSD - The Power to Serve!           Live free or die
-----BEGIN PGP SIGNATURE-----

iQEcBAEBCgAGBQJRW1dUAAoJEG80Jeu8UPuzGCMH/jFEX86BR3ozZDS5TPs5XSJI
MvjEf3wLllaA+HG2NtVCbKVhMxZvnt4RyQSCWlNHietefiG2uizHu/wf7PXkgTtQ
Z1yqElo2pXbLVY1jMkp91yVNAsE1hwoyUASc+V3LgZijXTvw10AWqpQI54yOyNfj
nLn7ic8Tnwa1a05JPoAabsCLAQ9YNStaEt6bo6180gXiD7gBHLibTaD0OuRIVgej
wOnSfI1o1XK2veYo04PVZLdGEEHeK+mbF1EPna7K6K6EwZ7vfsk6NGp9882lpoKj
LsW8ctnANUNv8hjfwOCUDQUW1NpjUDzkNvnt4Nfkh9TFfBsZjvbfxfEgS6W62Qk=
=UGCv
-----END PGP SIGNATURE-----
-------------- next part --------------
Index: cddl/contrib/opensolaris/cmd/zpool/zpool_main.c
===================================================================
--- cddl/contrib/opensolaris/cmd/zpool/zpool_main.c	(revision 249032)
+++ cddl/contrib/opensolaris/cmd/zpool/zpool_main.c	(working copy)
@@ -856,6 +856,17 @@ zpool_do_create(int argc, char **argv)
 		}
 	}
 
+	/* Compatiblity with 9.0 and 9.1: Use version 28 if unspecified */
+	if (nvlist_lookup_string(props,
+	    zpool_prop_to_name(ZPOOL_PROP_VERSION),
+	    &propval) != 0) {
+		if (add_prop_list(zpool_prop_to_name(
+		    ZPOOL_PROP_VERSION), "28", &props, B_TRUE))
+			goto errout;
+		enable_all_pool_feat = B_FALSE;
+	} else if (enable_all_pool_feat)
+		nvlist_remove_all(props, zpool_prop_to_name(ZPOOL_PROP_VERSION));
+
 	argc -= optind;
 	argv += optind;