[PATCH] Consistently use zfs_ioctl()

Martin Matuska mm at FreeBSD.org
Tue Jul 26 20:55:13 UTC 2011


I have chatted with delphij@ and he said his problem was in zfs jail /
unjail.

The problem is in zfs_jail(), cmd passed to ioctl() is initialized as
int instead of unsigned long.
Patch suggested for fixing this problem is attached.

-- 
Martin Matuska
FreeBSD committer
http://blog.vx.sk
-------------- next part --------------
Index: cddl/contrib/opensolaris/lib/libzfs/common/libzfs_dataset.c
===================================================================
--- cddl/contrib/opensolaris/lib/libzfs/common/libzfs_dataset.c	(revision 224409)
+++ cddl/contrib/opensolaris/lib/libzfs/common/libzfs_dataset.c	(working copy)
@@ -4289,7 +4289,8 @@
 	libzfs_handle_t *hdl = zhp->zfs_hdl;
 	zfs_cmd_t zc = { 0 };
 	char errbuf[1024];
-	int cmd, ret;
+	unsigned long cmd;
+	int ret;
 
 	if (attach) {
 		(void) snprintf(errbuf, sizeof (errbuf),


More information about the zfs-devel mailing list