zfs_cmd_t size issue.

[Pawel Jakub Dawidek]

On Mon, Jul 26, 2010 at 12:55:45PM +0530, Samir Desai wrote:
> hi Pawel
> 
> Shouldn't the MAX ioctl size be defined to
> 
> #define	IOCPARM_MAX	((1 << IOCPARM_SHIFT) - 1 )
> 
> Strictly speaking size 8192 can not be encoded.

You are right. Actually, now that we can use all the bits, this check in
sys/kern/sys_generic.c:ioctl() is pointless:

	size = IOCPARM_LEN(com);
	if ((size > IOCPARM_MAX) || [...]

I think I'll just remove IOCPARM_MAX entirely.

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
pjd at FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/zfs-devel/attachments/20100728/c37a383e/attachment.pgp