question about MAC policy modules on 6.0

Robert Watson rwatson at FreeBSD.org
Thu Mar 9 14:08:49 UTC 2006


On Wed, 8 Mar 2006, Hiroki Sato wrote:

> 4) mount_ufs(8) multilabel option
>
>  mount_ufs(8) has multilabel option for the MAC label, but it
>  seems broken ("tunefs -l enable" works, though).  I am not sure
>  the attached patch (the second one) is correct, but it should
>  fix this.

It's been a while since I've looked at this code, and have not had a chance to 
test your patch as yet.  The desired behavior is that mount be able to report 
that multilabel is set on the file system, and request that it be set when 
mounting the file system, but that the flag cannot be changed while running. 
The cache model on vnode labels basically means we assume the underlying label 
storage won't change except through the supported MAC APIs, and the mechanisms 
are not in place to walk the current vnode list to re-synchronize if the 
backing store changes (i.e., is enabled).  So as long as your patch doesn't 
add the ability to modify the flag at run-time, it sounds good to me.  In 
principle the kernel shouldn't allow it regardless of what mount requests, of 
course.

Robert N M Watson


More information about the trustedbsd-discuss mailing list