PERFORCE change 93645 for review

John Baldwin jhb at freebsd.org
Mon Mar 20 20:43:58 UTC 2006


On Monday 20 March 2006 15:06, Christian S.J. Peron wrote:
> Todd Miller wrote:
> 
> >http://perforce.freebsd.org/chv.cgi?CH=93645
> >
> >Change 93645 by millert at millert_p3 on 2006/03/20 17:51:24
> >
> >	Arg pointer in mac_thread_syscall_{enter,exit} should be
> >	register_t * not int *.  Fixes compilation problem on amd64.
> >
> >Affected files ...
> >
> >.. //depot/projects/trustedbsd/sebsd/sys/security/mac/mac_system.c#10 edit
> >
> >Differences ...
> >
> >==== //depot/projects/trustedbsd/sebsd/sys/security/mac/mac_system.c#10 (text+ko) ====
> >
> >@@ -282,7 +282,7 @@
> > }
> > 
> > int
> >-mac_thread_syscall_enter(struct thread *td, int *args, int code)
> >+mac_thread_syscall_enter(struct thread *td, register_t *args, int code)
> > {
> > 	int error;
> > 
> >@@ -293,7 +293,7 @@
> > }
> > 
> > void
> >-mac_thread_syscall_exit(struct thread *td, int *args, int code, int errcode)
> >+mac_thread_syscall_exit(struct thread *td, register_t *args, int code, int errcode)
> > {
> > 
> > 	if (!mac_enforce_syscall)
> >
> >
> >  
> >
> Does this still build on i386?

Probably, register_t == int on i386.  This is the right change though,
syscall arguments are typically passed in registers and/or on the stack,
and stack values should fit in registers.

-- 
John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org


More information about the trustedbsd-cvs mailing list