PERFORCE change 84051 for review

Robert Watson rwatson at FreeBSD.org
Wed Sep 21 11:58:23 GMT 2005


http://perforce.freebsd.org/chv.cgi?CH=84051

Change 84051 by rwatson at rwatson_zoo on 2005/09/21 11:57:45

	Be less agressive about removing Giant around vn_close(), we're not
	quite there yet.

Affected files ...

.. //depot/projects/trustedbsd/audit3/sys/security/audit/kern_audit.c#36 edit

Differences ...

==== //depot/projects/trustedbsd/audit3/sys/security/audit/kern_audit.c#36 (text+ko) ====

@@ -561,6 +561,7 @@
 	TAILQ_HEAD(, kaudit_record) ar_worklist;
 	struct kaudit_record *ar;
 	struct vnode *audit_vp, *old_vp;
+	int vfslocked;
 
 	struct ucred *audit_cred, *old_cred;
 	struct thread *audit_td;
@@ -605,8 +606,10 @@
 			if (old_vp != NULL) {
 				AUDIT_PRINTF(("Closing old audit file\n"));
 				mtx_unlock(&audit_mtx);
+				vfslocked = VFS_LOCK_GIANT(old_vp->v_mount);
 				vn_close(old_vp, audit_close_flags, old_cred,
 				    audit_td);
+				VFS_UNLOCK_GIANT(vfslocked);
 				crfree(old_cred);
 				mtx_lock(&audit_mtx);
 				old_cred = NULL;
To Unsubscribe: send mail to majordomo at trustedbsd.org
with "unsubscribe trustedbsd-cvs" in the body of the message



More information about the trustedbsd-cvs mailing list