PERFORCE change 84038 for review

Robert Watson rwatson at FreeBSD.org
Wed Sep 21 10:31:32 GMT 2005


http://perforce.freebsd.org/chv.cgi?CH=84038

Change 84038 by rwatson at rwatson_zoo on 2005/09/21 10:31:16

	Don't unconditionally assert Giant when auditing a path -- rely on
	the caller to acquire Giant if needed, and assert based on need.

Affected files ...

.. //depot/projects/trustedbsd/audit3/sys/security/audit/kern_audit.c#30 edit

Differences ...

==== //depot/projects/trustedbsd/audit3/sys/security/audit/kern_audit.c#30 (text+ko) ====

@@ -2359,9 +2359,10 @@
 		return;
 
 	/*
-	 * XXXAUDIT: Less Giant needed here.
+	 * Assume that if the caller is calling audit_arg_vnpath() on a
+	 * non-MPSAFE vnode, then it will have acquired Giant.
 	 */
-	mtx_assert(&Giant, MA_OWNED);
+	VFS_ASSERT_GIANT(vp->v_mount);
 	ASSERT_VOP_LOCKED(vp, "audit_arg_vnpath");
 
 	ar = currecord();
To Unsubscribe: send mail to majordomo at trustedbsd.org
with "unsubscribe trustedbsd-cvs" in the body of the message



More information about the trustedbsd-cvs mailing list