PERFORCE change 36517 for review

Robert Watson rwatson at
Wed Aug 20 19:42:15 GMT 2003

Change 36517 by rwatson at rwatson_tislabs on 2003/08/20 12:41:52

	IP fragment reassembly queues now potentially return an
	allocation failure since they are allocated while holding
	network mutexes and in interrupt context.  As such, we need
	to use the waitcheck version of the network label allocation
	code in SEBSD.  Otherwise, we use a function that calls
	MALLOC with M_WAITOK, generating a witness warning, and
	returns void, which likely causes IPQ allocation to fail
	in the MAC Framework.  This prevented fragment reassembly
	from working with the SEBSD module loaded, breaking NFS
	(and no doubt other good stuff).

Affected files ...

.. //depot/projects/trustedbsd/sebsd/sys/security/sebsd/sebsd.c#14 edit

Differences ...

==== //depot/projects/trustedbsd/sebsd/sys/security/sebsd/sebsd.c#14 (text+ko) ====

@@ -1929,7 +1929,7 @@
 	.mpo_init_devfsdirent_label = sebsd_init_vnode_label,
 	.mpo_init_file_label = sebsd_init_file_label,
 	.mpo_init_ifnet_label = sebsd_init_network_label,
-	.mpo_init_ipq_label = sebsd_init_network_label,
+	.mpo_init_ipq_label = sebsd_init_network_label_waitcheck,
 	.mpo_init_mbuf_label = sebsd_init_network_label_waitcheck,
 	.mpo_init_mount_label = sebsd_init_mount_label,
 	.mpo_init_mount_fs_label = sebsd_init_mount_fs_label,
To Unsubscribe: send mail to majordomo at
with "unsubscribe trustedbsd-cvs" in the body of the message

More information about the trustedbsd-cvs mailing list