PERFORCE change 35655 for review

Robert Watson rwatson at
Sun Aug 17 15:32:52 GMT 2003

On Sat, 16 Aug 2003, Pawel Jakub Dawidek wrote:

> On Wed, Aug 06, 2003 at 02:20:44PM -0700, Robert Watson wrote:
> +> -    mode ~= cmask;
> +> +    mode = mode &~ cmask;
> IMHO this is a style bug. 
> This should be: mode = mode & ~cmask; 
> On time, when I was tired, I've spend few minutes wondering why 'foo'
> after this operation isn't equal to 'foo - bar':) 
> 	foo =- bar;

Heh. :-)

Yeah -- all these instances of mode/cmask combination will move into a
centralized function in the next pass, similar to the
acl_posix1e_newfilemode() function (which will also gain a cmask
argument).  In the current pass, I'm trying to hit every place where modes
and masks will be combined at the file system level. 

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert at      Network Associates Laboratories

To Unsubscribe: send mail to majordomo at
with "unsubscribe trustedbsd-cvs" in the body of the message

More information about the trustedbsd-cvs mailing list