PERFORCE change 17505 for review

[Robert Watson]

http://people.freebsd.org/~peter/p4db/chv.cgi?CH=17505

Change 17505 by rwatson at rwatson_paprika on 2002/09/14 21:13:42

	Update comments to be more suggestive about how the back-end
	installer should be hooked in.

Affected files ...

.. //depot/projects/trustedbsd/misc/kmlsinstall/kmlsinstaller.cc#2 edit

Differences ...

==== //depot/projects/trustedbsd/misc/kmlsinstall/kmlsinstaller.cc#2 (text+ko) ====

@@ -97,7 +97,9 @@
 	wizard->setHelpEnabled(page1, FALSE);
 
 	/*
-	 * Page 2: Configuration options.
+	 * Page 2: Configuration options.  Any necessary choices regarding
+	 * the installation process should go on this page, or pages
+	 * inserted immediately following it.
 	 */
 	QVBox *page2 = new QVBox(wizard);
 
@@ -131,7 +133,7 @@
 	wizard->setHelpEnabled(page2, FALSE);
 
 	/*
-	 * Page 3: Conclusion.
+	 * Page 3: Conclusion.  Last warnings issued here.
 	 */
 	QLabel *page3 = new QLabel(wizard);
 	page3->setText(
@@ -168,10 +170,20 @@
 	if (wizard->exec() == FALSE)
 		close();
 
+	/*
+	 * Don't permit the window to be closed from here until the
+	 * installation is done.
+	 */
 	exit_ok = false;
 
-	/* Install happens here, I suppose. */
-
+	/*
+	 * Install happens here, I suppose.  Any configuration options
+	 * selected by the user should be applied.  Adjust the number
+	 * of steps below to reflect real-world steps.  Update the
+	 * status bar if needed, or status information on the Progress
+	 * Dialog.  Presumably invoking system() is the way to go
+	 * when calling out to scripts.
+	 */
 	QProgressDialog *progressdialog = new QProgressDialog(this,
 	    "TrustedBSD MLS Installation in Progress", TRUE);
 	progressdialog->setTotalSteps(5);
@@ -191,6 +203,10 @@
 	QMessageBox::information(this, "MLS Installation Complete!",
 	    "MLS support is now installed; reboot the system to start MLS.");
 
+	/*
+	 * Re-enable window closing so that we can generate an exit
+	 * event.
+	 */
 	exit_ok = true;
 
 	KMainWindow::close();
To Unsubscribe: send mail to majordomo at trustedbsd.org
with "unsubscribe trustedbsd-cvs" in the body of the message