PERFORCE change 18474 for review

Robert Watson rwatson at freebsd.org
Tue Oct 1 16:48:48 GMT 2002


http://people.freebsd.org/~peter/p4db/chv.cgi?CH=18474

Change 18474 by rwatson at rwatson_paprika on 2002/10/01 09:48:00

	Lock the pipe object while copying its label for return to the
	user.  This will prevent races involving simultaneous
	retrieval and setting of the pipe label.

Affected files ...

.. //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#286 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#286 (text+ko) ====

@@ -3807,8 +3807,9 @@
 		mac_init_pipe_label(&intlabel);
 		destroy_label = 1;
 
-		/* XXXMAC: Need pipe locking here. */
+		PIPE_LOCK(pipe);
 		mac_copy_pipe_label(pipe->pipe_label, &intlabel);
+		PIPE_UNLOCK(pipe);
 		break;
 	default:
 		error = EINVAL;
To Unsubscribe: send mail to majordomo at trustedbsd.org
with "unsubscribe trustedbsd-cvs" in the body of the message



More information about the trustedbsd-cvs mailing list