svn commit: r332012 - in vendor/opencsd: . dist dist/decoder dist/decoder/build dist/decoder/build/linux dist/decoder/build/linux/rctdl_c_api_lib dist/decoder/build/linux/ref_trace_decode_lib dist/...

[Ruslan Bukin]

On Wed, Apr 04, 2018 at 09:11:29AM -0700, Rodney W. Grimes wrote:
> [ Charset UTF-8 unsupported, converting... ]
> > On Wed, Apr 04, 2018 at 08:02:04AM -0700, Rodney W. Grimes wrote:
> > > > Author: br
> > > > Date: Wed Apr  4 12:33:46 2018
> > > > New Revision: 332012
> > > > URL: https://svnweb.freebsd.org/changeset/base/332012
> > > > 
> > > > Log:
> > > >   Import OpenCSD -- an ARM CoreSight Trace Decode library.
> > > 
> > > Why does this need to be in base?
> > > Is there some reason it can not live as a port?
> > > 
> > 
> > Yes opencsd is a dependancy for pmctrace(1) -- new HWPMC tracing tool.
> 
> Why does pmctrace(1) need to be in base?
> I can see that there is kernel driver code to support this,
> is it to keep the userland pmctrace(1) closely coupled to
> the kernel hwpmc(4) code?
> 

pmctrace(1) is part of hwpmc, i.e. it is using its facilities, similar to pmcstat(1).

> I shall assert this code also has a broken license form,
> if you read LICENSE there is no copyright "above" to
> retain, or print for a binary release.  As a consumer of
> that LICENSE technically I have to display nothing.
> I am sure that is not the desired intent.
> 
> I believe this is still under review without formal policy
> from core.

You are right. I just asked maintainter to fix this.
Thanks

Ruslan