svn commit: r323534 - vendor-sys/illumos/dist/uts/common/fs/zfs

[Andriy Gapon]

Author: avg
Date: Wed Sep 13 10:57:52 2017
New Revision: 323534
URL: https://svnweb.freebsd.org/changeset/base/323534

Log:
  8590 memory leak in dsl_destroy_snapshots_nvl()
  
  illumos/illumos-gate at e6ab4525d156c82445c116ecf6b2b874d5e9009d
  https://github.com/illumos/illumos-gate/commit/e6ab4525d156c82445c116ecf6b2b874d5e9009d
  
  https://www.illumos.org/issues/8590
    In dsl_destroy_snapshots_nvl(), "snaps_normalized" is not freed after it is
    added to "arg".
  
  Reviewed by: Pavel Zakharov <pavel.zakharov at delphix.com>
  Reviewed by: Steve Gonczi <steve.gonczi at delphix.com>
  Reviewed by: George Wilson <george.wilson at delphix.com>
  Approved by: Dan McDonald <danmcd at joyent.com>
  Author: Matthew Ahrens <mahrens at delphix.com>

Modified:
  vendor-sys/illumos/dist/uts/common/fs/zfs/dsl_destroy.c

Modified: vendor-sys/illumos/dist/uts/common/fs/zfs/dsl_destroy.c
==============================================================================
--- vendor-sys/illumos/dist/uts/common/fs/zfs/dsl_destroy.c	Wed Sep 13 10:56:19 2017	(r323533)
+++ vendor-sys/illumos/dist/uts/common/fs/zfs/dsl_destroy.c	Wed Sep 13 10:57:52 2017	(r323534)
@@ -501,6 +501,7 @@ dsl_destroy_snapshots_nvl(nvlist_t *snaps, boolean_t d
 		    nvpair_name(pair), B_TRUE);
 	}
 	fnvlist_add_nvlist(arg, "snaps", snaps_normalized);
+	fnvlist_free(snaps_normalized);
 	fnvlist_add_boolean_value(arg, "defer", defer);
 
 	nvlist_t *wrapper = fnvlist_alloc();