svn commit: r299818 - user/ngie/bsnmp_cleanup/contrib/bsnmp/snmpd

Gleb Smirnoff glebius at FreeBSD.org
Wed May 18 22:50:10 UTC 2016


On Wed, May 18, 2016 at 03:49:24PM -0700, Gleb Smirnoff wrote:
T> On Sun, May 15, 2016 at 01:10:32AM +0000, Garrett Cooper wrote:
T> G> Author: ngie
T> G> Date: Sun May 15 01:10:31 2016
T> G> New Revision: 299818
T> G> URL: https://svnweb.freebsd.org/changeset/base/299818
T> G> 
T> G> Log:
T> G>   Test laddr.s_addr against NULL, not 0
T> G> 
T> G> Modified:
T> G>   user/ngie/bsnmp_cleanup/contrib/bsnmp/snmpd/main.c
T> G> 
T> G> Modified: user/ngie/bsnmp_cleanup/contrib/bsnmp/snmpd/main.c
T> G> ==============================================================================
T> G> --- user/ngie/bsnmp_cleanup/contrib/bsnmp/snmpd/main.c	Sun May 15 00:54:21 2016	(r299817)
T> G> +++ user/ngie/bsnmp_cleanup/contrib/bsnmp/snmpd/main.c	Sun May 15 01:10:31 2016	(r299818)
T> G> @@ -1220,7 +1220,7 @@ snmpd_input(struct port_input *pi, struc
T> G>  		
T> G>  		ret = recv_dgram(pi, &laddr);
T> G>  
T> G> -		if (laddr.s_addr == 0) {
T> G> +		if (laddr.s_addr == NULL) {
T> G>  			msg.msg_control = NULL;
T> G>  			msg.msg_controllen = 0;
T> G>  		}
T> 
T> This change also seems incorrect. It isn't a pointer.

And I missed the next commit :)

-- 
Totus tuus, Glebius.


More information about the svn-src-user mailing list