svn commit: r299561 - user/ngie/ntb-hacking/sys/dev/ntb/if_ntb
Garrett Cooper
ngie at FreeBSD.org
Thu May 12 19:50:16 UTC 2016
Author: ngie
Date: Thu May 12 19:50:14 2016
New Revision: 299561
URL: https://svnweb.freebsd.org/changeset/base/299561
Log:
Remove bogus if_free (before ether_ifattach) when ntb_transport_probe fails
if_free does a lot more than just free memory; it stops packet processing.
This might fix panic on detach after r290684 when the transport is already in
use, i.e. when the net_softc context is fully populated and "valid" due to
use in another subsystem that's directly poking at ntb_hw0
Modified:
user/ngie/ntb-hacking/sys/dev/ntb/if_ntb/if_ntb.c
Modified: user/ngie/ntb-hacking/sys/dev/ntb/if_ntb/if_ntb.c
==============================================================================
--- user/ngie/ntb-hacking/sys/dev/ntb/if_ntb/if_ntb.c Thu May 12 19:47:37 2016 (r299560)
+++ user/ngie/ntb-hacking/sys/dev/ntb/if_ntb/if_ntb.c Thu May 12 19:50:14 2016 (r299561)
@@ -419,7 +419,6 @@ ntb_setup_interface(void)
rc = ntb_transport_probe(net_softc.ntb);
if (rc != 0) {
printf("ntb: Cannot init transport: %d\n", rc);
- if_free(net_softc.ifp);
return (rc);
}
More information about the svn-src-user
mailing list