svn commit: r303397 - user/alc/PQ_LAUNDRY/sys/vm

Alan Cox alc at FreeBSD.org
Wed Jul 27 16:46:49 UTC 2016


Author: alc
Date: Wed Jul 27 16:46:48 2016
New Revision: 303397
URL: https://svnweb.freebsd.org/changeset/base/303397

Log:
  Reactivation is still the best way of handling VM_PAGER_{ERROR,FAIL} in
  vm_pageout_flush().
  
  Reviewed by:	markj
  Sponsored by:	EMC / Isilon Storage Division

Modified:
  user/alc/PQ_LAUNDRY/sys/vm/vm_pageout.c

Modified: user/alc/PQ_LAUNDRY/sys/vm/vm_pageout.c
==============================================================================
--- user/alc/PQ_LAUNDRY/sys/vm/vm_pageout.c	Wed Jul 27 16:34:19 2016	(r303396)
+++ user/alc/PQ_LAUNDRY/sys/vm/vm_pageout.c	Wed Jul 27 16:46:48 2016	(r303397)
@@ -581,12 +581,12 @@ vm_pageout_flush(vm_page_t *mc, int coun
 		case VM_PAGER_ERROR:
 		case VM_PAGER_FAIL:
 			/*
-			 * If page couldn't be paged out, then reactivate the
-			 * page so it doesn't clog the XXX list.  (We
-			 * will try paging out it again later).
+			 * If the page couldn't be paged out, then reactivate
+			 * it so that it doesn't clog the laundry and inactive
+			 * queues.  (We will try paging it out again later).
 			 */
 			vm_page_lock(mt);
-			vm_page_activate(mt);	// XXX
+			vm_page_activate(mt);
 			vm_page_unlock(mt);
 			if (eio != NULL && i >= mreq && i - mreq < runlen)
 				*eio = TRUE;


More information about the svn-src-user mailing list