svn commit: r295193 - user/ngie/bsnmp_cleanup/contrib/bsnmp/snmp_mibII

[Garrett Cooper]

Author: ngie
Date: Wed Feb  3 02:14:31 2016
New Revision: 295193
URL: https://svnweb.freebsd.org/changeset/base/295193

Log:
  Return `ret` in op_ifentry(..) to mute a -Wunused-but-set-variable
  warning
  
  This should also now undetected error conditions with
  value->var.subs[sub - 1] == LEAF_ifPhysAddress where `string_get(..)`
  could fail if iifp->physaddr and/or iifp->physaddrlen were deemed
  invalid.
  
  Reported by: Jenkins (clang job) [1], Jenkins (gcc 4.9 job) [2]
  Sponsored by: EMC / Isilon Storage Division

Modified:
  user/ngie/bsnmp_cleanup/contrib/bsnmp/snmp_mibII/mibII_interfaces.c

Modified: user/ngie/bsnmp_cleanup/contrib/bsnmp/snmp_mibII/mibII_interfaces.c
==============================================================================
--- user/ngie/bsnmp_cleanup/contrib/bsnmp/snmp_mibII/mibII_interfaces.c	Wed Feb  3 02:08:55 2016	(r295192)
+++ user/ngie/bsnmp_cleanup/contrib/bsnmp/snmp_mibII/mibII_interfaces.c	Wed Feb  3 02:14:31 2016	(r295193)
@@ -356,7 +356,7 @@ op_ifentry(struct snmp_context *ctx, str
 		value->v.oid = ifp->spec_oid;
 		break;
 	}
-	return (SNMP_ERR_NOERROR);
+	return (ret);
 }
 
 /*