svn commit: r248185 - user/attilio/vmcontention/sys/vm

[Attilio Rao]

On Tue, Mar 12, 2013 at 1:04 PM, Attilio Rao <attilio at freebsd.org> wrote:
> On Tue, Mar 12, 2013 at 7:14 AM, Alan Cox <alc at freebsd.org> wrote:
>> Author: alc
>> Date: Tue Mar 12 06:14:31 2013
>> New Revision: 248185
>> URL: http://svnweb.freebsd.org/changeset/base/248185
>>
>> Log:
>>   When transferring the page from one object to another, don't insert the
>>   page into its new object until the page's pindex has been updated.
>>   Otherwise, one code path within vm_radix_insert() may use the wrong
>>   pindex value.
>
> This is just a style change really because the code already subtracts
> offindxstart from current m->pindex when inserting. The pindex on the
> page is then adjusted when the real subtraction happens.
> IIRC, I did this way because of less diffs against -CURRENT, but the
> code looks correct to me already in the older version.

Also, I would reduce at minimum the functional changes that could just
introduce bugs against a well-tested implementation.

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein