svn commit: r248162 - user/attilio/vmobj-readlock/sys/vm
Attilio Rao
attilio at freebsd.org
Mon Mar 11 19:25:59 UTC 2013
On Mon, Mar 11, 2013 at 6:05 PM, Alan Cox <alc at rice.edu> wrote:
> On 03/11/2013 08:50, Attilio Rao wrote:
>> Author: attilio
>> Date: Mon Mar 11 13:50:40 2013
>> New Revision: 248162
>> URL: http://svnweb.freebsd.org/changeset/base/248162
>>
>> Log:
>> The VM_ALLOC_IFCACHED case does not require any object locking as
>> it will only go through the object page cache and return.
>> Lookups in the object's page cache are correctly handled by
>> the vm_page_queue_free_mtx, which will be acquired correctly in this
>> case.
>> Relax the locking assertion.
>>
>
> Umm, no. The page is moving from the cache to the rtree. Insertion
> into the latter requires the object to be write locked.
Yeah, I figured out while I was having gym training :)
Huge brainfart, I'll revert soon.
Attilio
--
Peace can only be achieved by understanding - A. Einstein
More information about the svn-src-user
mailing list