svn commit: r247772 - user/attilio/vmc-playground/sys/vm
Alan Cox
alc at FreeBSD.org
Mon Mar 4 07:21:00 UTC 2013
Author: alc
Date: Mon Mar 4 07:20:59 2013
New Revision: 247772
URL: http://svnweb.freebsd.org/changeset/base/247772
Log:
A Boolean is more appropriate than an int here. Use what I think is a
slightly better variable name.
Sponsored by: EMC / Isilon Storage Division
Modified:
user/attilio/vmc-playground/sys/vm/vm_page.c
Modified: user/attilio/vmc-playground/sys/vm/vm_page.c
==============================================================================
--- user/attilio/vmc-playground/sys/vm/vm_page.c Mon Mar 4 07:11:10 2013 (r247771)
+++ user/attilio/vmc-playground/sys/vm/vm_page.c Mon Mar 4 07:20:59 2013 (r247772)
@@ -2132,7 +2132,7 @@ void
vm_page_cache(vm_page_t m)
{
vm_object_t object;
- int old_empty_cache;
+ boolean_t cache_was_empty;
vm_page_lock_assert(m, MA_OWNED);
object = m->object;
@@ -2184,8 +2184,8 @@ vm_page_cache(vm_page_t m)
m->flags &= ~PG_ZERO;
mtx_lock(&vm_page_queue_free_mtx);
m->flags |= PG_CACHED;
- old_empty_cache = vm_object_cache_is_empty(object);
cnt.v_cache_count++;
+ cache_was_empty = vm_object_cache_is_empty(object);
vm_radix_insert(&object->cache, m->pindex, m);
#if VM_NRESERVLEVEL > 0
if (!vm_reserv_free_page(m)) {
@@ -2204,10 +2204,9 @@ vm_page_cache(vm_page_t m)
* the object's only resident page.
*/
if (object->type == OBJT_VNODE) {
- if (old_empty_cache != 0 && object->resident_page_count != 0)
+ if (cache_was_empty && object->resident_page_count != 0)
vhold(object->handle);
- else if (old_empty_cache == 0 &&
- object->resident_page_count == 0)
+ else if (!cache_was_empty && object->resident_page_count == 0)
vdrop(object->handle);
}
}
More information about the svn-src-user
mailing list