svn commit: r246878 - user/crees/rclint

[Chris Rees]

Author: crees (ports committer)
Date: Sat Feb 16 17:47:47 2013
New Revision: 246878
URL: http://svnweb.freebsd.org/changeset/base/246878

Log:
  Check properly for quoted variables when deciding on pointlessness
  
  Submitted by:	bdrewery

Modified:
  user/crees/rclint/Makefile
  user/crees/rclint/rclint.py

Modified: user/crees/rclint/Makefile
==============================================================================
--- user/crees/rclint/Makefile	Sat Feb 16 15:11:40 2013	(r246877)
+++ user/crees/rclint/Makefile	Sat Feb 16 17:47:47 2013	(r246878)
@@ -21,6 +21,9 @@ FILES=	${SCRIPT} errors.en problems.en
 
 .PHONY: majorbump minorbump microbump release
 
+all:
+	@${ECHO} majorbump, minorbump, microbump and tarball are valid targets
+
 majorbump:
 	M=$$(expr ${VERSION_MAJOR} + 1); \
 	${SED} -i '' -e "s,^\(MAJOR = \).*,\1$$M," ${SCRIPT}

Modified: user/crees/rclint/rclint.py
==============================================================================
--- user/crees/rclint/rclint.py	Sat Feb 16 15:11:40 2013	(r246877)
+++ user/crees/rclint/rclint.py	Sat Feb 16 17:47:47 2013	(r246878)
@@ -28,7 +28,7 @@ __version__ = '$FreeBSD$'
 
 MAJOR = 0
 MINOR = 0
-MICRO = 3
+MICRO = 4
 
 DATADIR = '.'
 
@@ -108,10 +108,11 @@ class Statement:
             return False
 
     def pointless_quoted(self):
-        if self.quoted():
-            for char in self.value:
-                if char in ' \t|&;<>()$`\\\"\'':
-                    return False
+        if not self.quoted():
+            return False
+        for char in self.value:
+            if char in ' \t|&;<>()$`\\\"\'':
+                return False
         return True
 
     def get_value(self):