svn commit: r250120 - user/crees/rclint

[Chris Rees]

Author: crees (ports committer)
Date: Tue Apr 30 21:36:52 2013
New Revision: 250120
URL: http://svnweb.freebsd.org/changeset/base/250120

Log:
  Add configfile to recommended 'clobberers'.
  
  Don't complain about quoting if %% substitution is used; there may be spaces in
  the substitution.

Modified:
  user/crees/rclint/rclint.py

Modified: user/crees/rclint/rclint.py
==============================================================================
--- user/crees/rclint/rclint.py	Tue Apr 30 20:53:28 2013	(r250119)
+++ user/crees/rclint/rclint.py	Tue Apr 30 21:36:52 2013	(r250120)
@@ -113,7 +113,7 @@ class Statement:
         if not self.quoted():
             return False
         for char in self.value[1:-1]:
-            if char in ' \t|&;<>()$`\\\"\'':
+            if char in ' \t|%&;<>()$`\\\"\'':
                 return False
         return True
 
@@ -270,7 +270,8 @@ def do_ports_checking(lineobj, filename)
     logging.debug('Checking for defaults clobbering blank values')
     for var in lineobj['Variable']:
         if var.type in ('longhand', 'shorthand'):
-            if var.name.split('_')[-1] not in ('enable', 'user', 'group') and var.clobber:
+            if var.name.split('_')[-1] not in ('enable', 'user', 'group',
+                                                'configfile') and var.clobber:
                 error.give('variables_defaults_non_mandatory_colon', var.line)
             elif not var.clobber and var.name.split('_')[-1] in ('enable'):
                 error.give('variables_defaults_mandatory_colon', var.line)