svn commit: r234532 - user/hrs/ipv6/sys/dev/usb
Hiroki Sato
hrs at FreeBSD.org
Sat Apr 21 06:29:45 UTC 2012
Author: hrs
Date: Sat Apr 21 06:29:44 2012
New Revision: 234532
URL: http://svn.freebsd.org/changeset/base/234532
Log:
- Fix ifname matching.
- Return non-zero status when unit < 0.
Modified:
user/hrs/ipv6/sys/dev/usb/usb_pf.c
Modified: user/hrs/ipv6/sys/dev/usb/usb_pf.c
==============================================================================
--- user/hrs/ipv6/sys/dev/usb/usb_pf.c Sat Apr 21 06:10:18 2012 (r234531)
+++ user/hrs/ipv6/sys/dev/usb/usb_pf.c Sat Apr 21 06:29:44 2012 (r234532)
@@ -129,7 +129,7 @@ usbpf_ifname2ubus(const char *ifname)
int unit;
int error;
- if (strncmp(ifname, USBUSNAME, sizeof(USBUSNAME)) <= 0)
+ if (strncmp(ifname, USBUSNAME, sizeof(USBUSNAME) - 1) != 0)
return (NULL);
error = ifc_name2unit(ifname, &unit);
if (error || unit < 0)
@@ -167,8 +167,10 @@ usbpf_clone_create(struct if_clone *ifc,
struct usb_bus *ubus;
error = ifc_name2unit(name, &unit);
- if (error || unit < 0)
+ if (error)
return (error);
+ if (unit < 0)
+ return (EINVAL);
ubus = usbpf_ifname2ubus(name);
if (ubus == NULL)
More information about the svn-src-user
mailing list