svn commit: r222060 - in user/avg/xcpu/sys: kern sys

[Andriy Gapon]

on 29/05/2011 06:08 Attilio Rao said the following:
> 2011/5/27 Andriy Gapon <avg at freebsd.org>:
>> on 26/05/2011 19:41 Attilio Rao said the following:
>>> Yes, I think it would be better something like SYSTEM_IN_PANIC() or such.
>>
>> How about SCHEDULER_STOPPED() ?
>>
> 
> I think the name should be in the "panic" ballpark rather than the
> "scheduler" one.

Actually I am growing fond of this name as it accurately reflects state of a
system and why we want to skip locks.  OTOH, I can not imagine other cases
besides panic where we would want to stop scheduler and skip locks, so maybe
something like SCHEDULER_STOPPED_ IN/BY/FOR _PANIC ?
SCHEDULER_STOPPED looks more appealing to me because of its brevity.

I also want to rename stop_cpus_on_panic knob to stop_scheduler_on_panic for all
the same reasons.  It would also control doing critical_enter() [as we do now]
vs spinlock_enter() [as I want to do], so it becomes used even in the UP case.

> Anyway I don't really care too much about the name, I just think we
> should have it in system.h, where also panic() lives.

I agree.

-- 
Andriy Gapon