svn commit: r225093 - in user/gabor/tre-integration: contrib/tre/lib include

[Andrey Chernov]

On Thu, Aug 25, 2011 at 01:22:55AM +0200, Gabor Kovesdan wrote:
> This change was a semi-temporary solution. I'm wondering whether I 
> should remove the underscore and consider it a normal knob as it may be 
> useful outside TRE, however I cannot think of any concrete case. 

If it will be direct user-visible flag, you'll need to discuss that with 
TRE author first, but I don't see, why it needs to be normal flag.

> What do you exactly mean by end of a word? 

I mean end of a word bits pool (opposite to start of it where all 
bit-occuped flags are grouped together).

> Still, binary compatibility will 
> break if a new POSIX flag will be introduced because TRE already defines 
> some extra flags. 

POSIX often does not specify exact numeric values of its flags.

If TRE author just add new flag, old binary still can run with new lib 
normally, since this place was not occuped previously. But if you 
separately use the same bit too, old binary can even run but produce 
strange results.

> I'm not quite sure which is the best solution. 

If it is supposed to be direct user-visible flag, it should be coordinated 
with TRE author or moved to the end of bits pool at least to delay 
conflict as much as possible. If it is pure internal flag, it should not 
be in that field and in the public header at all.

-- 
http://ache.vniz.net/