svn commit: r225132 - user/adrian/if_ath_tx/sys/dev/ath

[Adrian Chadd]

Author: adrian
Date: Wed Aug 24 06:59:59 2011
New Revision: 225132
URL: http://svn.freebsd.org/changeset/base/225132

Log:
  Add a comment describing what may occur during retries.
  Another thing to sort out before this is merged into -HEAD.

Modified:
  user/adrian/if_ath_tx/sys/dev/ath/if_ath.c

Modified: user/adrian/if_ath_tx/sys/dev/ath/if_ath.c
==============================================================================
--- user/adrian/if_ath_tx/sys/dev/ath/if_ath.c	Wed Aug 24 06:57:29 2011	(r225131)
+++ user/adrian/if_ath_tx/sys/dev/ath/if_ath.c	Wed Aug 24 06:59:59 2011	(r225132)
@@ -1907,10 +1907,13 @@ _ath_getbuf_locked(struct ath_softc *sc)
  * be again passed through the descriptor setup/chain routines
  * so the link is correct.
  *
- * XXX TODO: the source buffer is still valid; so the mbuf
- * XXX will be freed when that buffer is freed! The bf callback
- * XXX will be called too, etc, etc.
- * XXX so the caller must handle this somehow!
+ * The caller must free the buffer using ath_freebuf().
+ *
+ * XXX TODO: this call shouldn't fail as it'll cause packet loss
+ * XXX in the TX pathway when retries are needed.
+ * XXX Figure out how to keep some buffers free, or factor the
+ * XXX number of busy buffers into the xmit path (ath_start())
+ * XXX so we don't over-commit.
  */
 struct ath_buf *
 ath_buf_clone(struct ath_softc *sc, const struct ath_buf *bf)