svn commit: r224958 - user/adrian/if_ath_tx/sys/dev/ath

Adrian Chadd adrian at FreeBSD.org
Thu Aug 18 04:44:42 UTC 2011


Author: adrian
Date: Thu Aug 18 04:44:41 2011
New Revision: 224958
URL: http://svn.freebsd.org/changeset/base/224958

Log:
  Whilst auditing the code, I've found that my shuffling of ATH_BUF_BUSY handling
  is incorrect.
  
  Since this'll break the TDMA code (and I'd rather not do that),
  just leave a note for it to be revisited before this is merged
  back into -HEAD.

Modified:
  user/adrian/if_ath_tx/sys/dev/ath/if_ath.c

Modified: user/adrian/if_ath_tx/sys/dev/ath/if_ath.c
==============================================================================
--- user/adrian/if_ath_tx/sys/dev/ath/if_ath.c	Thu Aug 18 04:39:29 2011	(r224957)
+++ user/adrian/if_ath_tx/sys/dev/ath/if_ath.c	Thu Aug 18 04:44:41 2011	(r224958)
@@ -4425,6 +4425,11 @@ ath_tx_freebuf(struct ath_softc *sc, str
 	}
 	m_freem(bf->bf_m);
 	bf->bf_m = NULL;
+
+	/*
+	 * XXX This is incorrect. Check what the -HEAD code is doing.
+	 * XXX The TDMA code will be broken if this isn't properly repaired.
+	 */
 	bf->bf_flags &= ~ATH_BUF_BUSY;
 
 	ATH_TXBUF_LOCK(sc);


More information about the svn-src-user mailing list